Browse Source

Change /settings/preferences to redirect to appearance, add /settings/preferences/other (#10988)

tags/v2.9.0rc1
Eugen Rochko 3 months ago
parent
commit
560ec24e58
No account linked to committer's email address

+ 9
- 0
app/controllers/settings/preferences/other_controller.rb View File

@@ -0,0 +1,9 @@
# frozen_string_literal: true

class Settings::Preferences::OtherController < Settings::PreferencesController
private

def after_update_redirect_path
settings_preferences_other_path
end
end

app/views/settings/preferences/show.html.haml → app/views/settings/preferences/other/show.html.haml View File


+ 2
- 2
config/navigation.rb View File

@@ -10,10 +10,10 @@ SimpleNavigation::Configuration.run do |navigation|
s.item :identity_proofs, safe_join([fa_icon('key fw'), t('settings.identity_proofs')]), settings_identity_proofs_path, highlights_on: %r{/settings/identity_proofs*}, if: proc { current_account.identity_proofs.exists? }
end

n.item :preferences, safe_join([fa_icon('cog fw'), t('settings.preferences')]), settings_preferences_appearance_url do |s|
n.item :preferences, safe_join([fa_icon('cog fw'), t('settings.preferences')]), settings_preferences_url do |s|
s.item :appearance, safe_join([fa_icon('desktop fw'), t('settings.appearance')]), settings_preferences_appearance_url
s.item :notifications, safe_join([fa_icon('bell fw'), t('settings.notifications')]), settings_preferences_notifications_url
s.item :other, safe_join([fa_icon('cog fw'), t('preferences.other')]), settings_preferences_url
s.item :other, safe_join([fa_icon('cog fw'), t('preferences.other')]), settings_preferences_other_url
end

n.item :relationships, safe_join([fa_icon('users fw'), t('settings.relationships')]), relationships_url

+ 4
- 2
config/routes.rb View File

@@ -87,15 +87,17 @@ Rails.application.routes.draw do
get '/explore', to: 'directories#index', as: :explore
get '/explore/:id', to: 'directories#show', as: :explore_hashtag

get '/settings', to: redirect('/settings/preferences')
get '/settings', to: redirect('/settings/profile')

namespace :settings do
resource :profile, only: [:show, :update]
resource :preferences, only: [:show, :update]

get :preferences, to: redirect('/settings/preferences/appearance')

namespace :preferences do
resource :appearance, only: [:show, :update], controller: :appearance
resource :notifications, only: [:show, :update]
resource :other, only: [:show, :update], controller: :other
end

resource :import, only: [:show, :create]

spec/controllers/settings/preferences_controller_spec.rb → spec/controllers/settings/preferences/other_controller_spec.rb View File

@@ -1,6 +1,6 @@
require 'rails_helper'

describe Settings::PreferencesController do
describe Settings::Preferences::OtherController do
render_views

let(:user) { Fabricate(:user, filtered_languages: []) }
@@ -20,7 +20,7 @@ describe Settings::PreferencesController do
it 'updates the user record' do
put :update, params: { user: { locale: 'en', chosen_languages: ['es', 'fr', ''] } }

expect(response).to redirect_to(settings_preferences_path)
expect(response).to redirect_to(settings_preferences_other_path)
user.reload
expect(user.locale).to eq 'en'
expect(user.chosen_languages).to eq ['es', 'fr']
@@ -37,7 +37,7 @@ describe Settings::PreferencesController do
}
}

expect(response).to redirect_to(settings_preferences_path)
expect(response).to redirect_to(settings_preferences_other_path)
user.reload
expect(user.settings['boost_modal']).to be true
expect(user.settings['delete_modal']).to be false

Loading…
Cancel
Save