From cec7f0ed72966aa8fefaac61a0581a184d3c231e Mon Sep 17 00:00:00 2001 From: Matt Jankowski Date: Wed, 25 Oct 2023 03:12:32 -0400 Subject: [PATCH] Remove unused `#error_explanation` id from error partials (#27536) --- .haml-lint_todo.yml | 10 ++-------- app/views/oauth/authorizations/error.html.haml | 2 +- app/views/shared/_error_messages.html.haml | 2 +- 3 files changed, 4 insertions(+), 10 deletions(-) diff --git a/.haml-lint_todo.yml b/.haml-lint_todo.yml index d5f6912a6..c7209cdf7 100644 --- a/.haml-lint_todo.yml +++ b/.haml-lint_todo.yml @@ -1,13 +1,13 @@ # This configuration was generated by # `haml-lint --auto-gen-config` -# on 2023-10-23 10:16:00 -0400 using Haml-Lint version 0.51.0. +# on 2023-10-24 14:08:37 -0400 using Haml-Lint version 0.51.0. # The point is for the user to remove these configuration records # one by one as the lints are removed from the code base. # Note that changes in the inspected code, or installation of new # versions of Haml-Lint, may require this file to be generated again. linters: - # Offense count: 944 + # Offense count: 945 LineLength: enabled: false @@ -69,9 +69,3 @@ linters: - 'app/views/statuses/_simple_status.html.haml' - 'app/views/statuses_cleanup/show.html.haml' - 'app/views/user_mailer/warning.html.haml' - - # Offense count: 2 - IdNames: - exclude: - - 'app/views/oauth/authorizations/error.html.haml' - - 'app/views/shared/_error_messages.html.haml' diff --git a/app/views/oauth/authorizations/error.html.haml b/app/views/oauth/authorizations/error.html.haml index 408ca2b86..cd6e6f64e 100644 --- a/app/views/oauth/authorizations/error.html.haml +++ b/app/views/oauth/authorizations/error.html.haml @@ -1,3 +1,3 @@ .form-container - .flash-message#error_explanation + .flash-message = @pre_auth.error_response.body[:error_description] diff --git a/app/views/shared/_error_messages.html.haml b/app/views/shared/_error_messages.html.haml index 4916bd424..94841cc61 100644 --- a/app/views/shared/_error_messages.html.haml +++ b/app/views/shared/_error_messages.html.haml @@ -1,5 +1,5 @@ - if object.errors.any? - .flash-message.alert#error_explanation + .flash-message.alert %strong= t('generic.validation_errors', count: object.errors.count) - object.errors[:base].each do |error| .flash-message.alert