Claire c8dbbd60eb Fix error-prone SQL queries (#15828) ... * Fix error-prone SQL queries in Account search While this code seems to not present an actual vulnerability, one could easily be introduced by mistake due to how the query is built. This PR parameterises the `to_tsquery` input to make the query more robust. * Harden code for Status#tagged_with_all and Status#tagged_with_none Those two scopes aren't used in a way that could be vulnerable to an SQL injection, but keeping them unchanged might be a hazard. * Remove unneeded spaces surrounding tsquery term * Please CodeClimate * Move advanced_search_for SQL template to its own function This avoids one level of indentation while making clearer that the SQL template isn't build from all the dynamic parameters of advanced_search_for. * Add tests covering tagged_with, tagged_with_all and tagged_with_none * Rewrite tagged_with_none to avoid multiple joins and make it more robust * Remove obsolete brakeman warnings * Revert "Remove unneeded spaces surrounding tsquery term" The two queries are not strictly equivalent. This reverts commit 86f16c537e06c6ba4a8b250f25dcce9f049023ff.		2022-02-02 23:30:15 +01:00
..
account_suggestions	Change auto-following admin-selected accounts, show in recommendations (#16078)	2021-04-24 17:01:43 +02:00
admin	Add management of delivery availability in Federation settings (#15771)	2021-05-05 23:39:02 +02:00
concerns	Fix followers synchronization mechanism not working when URI has empty path (#16510)	2022-01-31 10:59:00 +01:00
form	Change auto-following admin-selected accounts, show in recommendations (#16078)	2021-04-24 17:01:43 +02:00
web	Add policy param to POST /api/v1/push/subscriptions (#16040)	2021-04-15 05:00:25 +02:00
account.rb	Fix error-prone SQL queries (#15828)	2022-02-02 23:30:15 +01:00
account_alias.rb
account_conversation.rb
account_deletion_request.rb
account_domain_block.rb
account_filter.rb
account_identity_proof.rb
account_migration.rb
account_moderation_note.rb
account_note.rb	Fix AccountNote not having a maximum length (#16942)	2021-11-06 00:17:05 +01:00
account_pin.rb
account_stat.rb	Fix account deletion sometimes failing because of optimistic locks (#16317)	2021-06-02 17:41:25 +02:00
account_suggestions.rb	Change auto-following admin-selected accounts, show in recommendations (#16078)	2021-04-24 17:01:43 +02:00
account_summary.rb	Fix FollowRecommendationsScheduler failing because of unpopulated views (#16189)	2021-05-09 10:39:29 +02:00
account_warning.rb
account_warning_preset.rb
admin.rb
announcement.rb
announcement_filter.rb
announcement_mute.rb
announcement_reaction.rb
application_record.rb
backup.rb
block.rb
bookmark.rb
canonical_email_block.rb	Fix error when suspending user with an already-existing canonical email block (#17036)	2021-11-26 01:22:10 +01:00
context.rb
conversation.rb
conversation_mute.rb
custom_emoji.rb
custom_emoji_category.rb
custom_emoji_filter.rb
custom_filter.rb
device.rb
domain_allow.rb
domain_block.rb
email_domain_block.rb
encrypted_message.rb
export.rb
favourite.rb
featured_tag.rb
feed.rb
follow.rb
follow_recommendation.rb	Fix FollowRecommendationsScheduler failing because of unpopulated views (#16189)	2021-05-09 10:39:29 +02:00
follow_recommendation_filter.rb	Add cold-start follow recommendations (#15945)	2021-04-12 12:37:14 +02:00
follow_recommendation_suppression.rb	Add cold-start follow recommendations (#15945)	2021-04-12 12:37:14 +02:00
follow_request.rb	Fix edge case where accepted follow cannot be processed because of follow limit (#16098)	2021-04-23 22:51:21 +02:00
home_feed.rb
identity.rb
import.rb
instance.rb	Add management of delivery availability in Federation settings (#15771)	2021-05-05 23:39:02 +02:00
instance_filter.rb	Add management of delivery availability in Federation settings (#15771)	2021-05-05 23:39:02 +02:00
invite.rb
invite_filter.rb
ip_block.rb
list.rb
list_account.rb
list_feed.rb
marker.rb
media_attachment.rb	Fix media processing getting stuck on too much stdin/stderr (#16136)	2021-05-05 19:44:01 +02:00
mention.rb
message_franking.rb
mute.rb
notification.rb
one_time_key.rb
poll.rb
poll_vote.rb
preview_card.rb
public_feed.rb
relationship_filter.rb
relay.rb
remote_follow.rb
report.rb
report_filter.rb
report_note.rb
rule.rb
scheduled_status.rb
search.rb
session_activation.rb	Add Ruby 3.0 support (#16046)	2021-05-06 14:22:54 +02:00
setting.rb
site_upload.rb
status.rb	Fix error-prone SQL queries (#15828)	2022-02-02 23:30:15 +01:00
status_pin.rb
status_stat.rb
system_key.rb
tag.rb	Change trending hashtags to be affected be reblogs (#16164)	2021-05-07 14:33:43 +02:00
tag_feed.rb
tag_filter.rb	Change trending hashtags to be affected be reblogs (#16164)	2021-05-07 14:33:43 +02:00
tombstone.rb
trending_tags.rb	Change trending hashtags to be affected be reblogs (#16164)	2021-05-07 14:33:43 +02:00
unavailable_domain.rb
user.rb	Fix reviving revoked sessions and invalidating login (#16943)	2021-11-06 00:17:05 +01:00
user_invite_request.rb
web.rb
webauthn_credential.rb