mastodon/app
Claire 0a120d86d2
Fix error-prone SQL queries (#15828)
* Fix error-prone SQL queries in Account search

While this code seems to not present an actual vulnerability, one could
easily be introduced by mistake due to how the query is built.

This PR parameterises the `to_tsquery` input to make the query more robust.

* Harden code for Status#tagged_with_all and Status#tagged_with_none

Those two scopes aren't used in a way that could be vulnerable to an SQL
injection, but keeping them unchanged might be a hazard.

* Remove unneeded spaces surrounding tsquery term

* Please CodeClimate

* Move advanced_search_for SQL template to its own function

This avoids one level of indentation while making clearer that the SQL template
isn't build from all the dynamic parameters of advanced_search_for.

* Add tests covering tagged_with, tagged_with_all and tagged_with_none

* Rewrite tagged_with_none to avoid multiple joins and make it more robust

* Remove obsolete brakeman warnings

* Revert "Remove unneeded spaces surrounding tsquery term"

The two queries are not strictly equivalent.

This reverts commit 86f16c537e06c6ba4a8b250f25dcce9f049023ff.
2022-01-23 18:10:10 +01:00
..
chewy Add trending links (#16917) 2021-11-25 13:07:38 +01:00
controllers Add OMNIAUTH_ONLY environment variable to enforce externa log-in (#17288) 2022-01-23 15:52:58 +01:00
helpers Add OMNIAUTH_ONLY environment variable to enforce externa log-in (#17288) 2022-01-23 15:52:58 +01:00
javascript Change percent to rate in retention metrics API (#16910) 2022-01-23 16:01:25 +01:00
lib Change percent to rate in retention metrics API (#16910) 2022-01-23 16:01:25 +01:00
mailers Add notifications for statuses deleted by moderators (#17204) 2022-01-17 09:41:33 +01:00
models Fix error-prone SQL queries (#15828) 2022-01-23 18:10:10 +01:00
policies Add ability for admins to delete canonical email blocks (#16644) 2021-12-17 23:02:14 +01:00
presenters Add graphs and retention metrics to admin dashboard (#16829) 2021-10-14 20:44:59 +02:00
serializers Change percent to rate in retention metrics API (#16910) 2022-01-23 16:01:25 +01:00
services Fix error when processing poll updates (#17333) 2022-01-19 22:50:01 +01:00
validators Add support for private pinned posts (#16954) 2022-01-17 00:49:55 +01:00
views Add OMNIAUTH_ONLY environment variable to enforce externa log-in (#17288) 2022-01-23 15:52:58 +01:00
workers Fix error when using raw distribution worker (#17334) 2022-01-19 23:05:59 +01:00