Akihiko Odaki ae871c4d46 Make Array-creation behavior of Paginable more predictable (#14687) ... * Make Array-creation behavior of Paginable more predictable Paginable.paginate_by_id usually returns ActiveRecord::Relation, but it returns an Array if min_id option is present. The behavior caused problems fixed with the following commits: - 552e886b64 - b63ede5005 - 64ef37b89d To prevent from recurring similar problems, this commit introduces two changes: - The scope now always returns an Array whether min_id option is present or not. - The scope is renamed to to_a_paginated_by_id to clarify it returns an Array. * Transform Paginable.to_a_paginated_by_id from a scope to a class method https://api.rubyonrails.org/classes/ActiveRecord/Scoping/Named/ClassMethods.html#method-i-scope > The method is intended to return an ActiveRecord::Relation object, which > is composable with other scopes. Paginable.to_a_paginated_by_id returns an Array and is not appropriate as a scope.		2020-08-31 12:47:09 +02:00
..
accounts	Introduce ApplicationController#cache_collection_paginated_by_id (#14677)	2020-08-28 12:31:56 +02:00
admin	Make Array-creation behavior of Paginable more predictable (#14687)	2020-08-31 12:47:09 +02:00
announcements
apps
crypto	Make Array-creation behavior of Paginable more predictable (#14687)	2020-08-31 12:47:09 +02:00
featured_tags
instances
lists
polls
push
statuses	Fix not being able to unbookmark toots when blocked by their author (#14604)	2020-08-19 19:02:06 +02:00
timelines	Introduce ApplicationController#cache_collection_paginated_by_id (#14677)	2020-08-28 12:31:56 +02:00
accounts_controller.rb
announcements_controller.rb
apps_controller.rb
blocks_controller.rb
bookmarks_controller.rb	Make Array-creation behavior of Paginable more predictable (#14687)	2020-08-31 12:47:09 +02:00
conversations_controller.rb	Make Array-creation behavior of Paginable more predictable (#14687)	2020-08-31 12:47:09 +02:00
custom_emojis_controller.rb
directories_controller.rb
domain_blocks_controller.rb
endorsements_controller.rb
favourites_controller.rb	Make Array-creation behavior of Paginable more predictable (#14687)	2020-08-31 12:47:09 +02:00
featured_tags_controller.rb
filters_controller.rb
follow_requests_controller.rb
instances_controller.rb
lists_controller.rb
markers_controller.rb
media_controller.rb	Add customizable thumbnails for audio and video attachments (#14145)	2020-06-29 13:56:55 +02:00
mutes_controller.rb
notifications_controller.rb	Introduce ApplicationController#cache_collection_paginated_by_id (#14677)	2020-08-28 12:31:56 +02:00
polls_controller.rb
preferences_controller.rb
reports_controller.rb
scheduled_statuses_controller.rb	Make Array-creation behavior of Paginable more predictable (#14687)	2020-08-31 12:47:09 +02:00
statuses_controller.rb	Fix/14021 behaviour on add or remove toots (#14212)	2020-07-19 17:04:02 +02:00
streaming_controller.rb
suggestions_controller.rb
trends_controller.rb