Add tests for embeds controller (#7719)

* Small refactoring of status_finder_spec

* Add tests for embeds_controller
This commit is contained in:
Shuhei Kitagawa 2018-06-04 10:35:56 +09:00 committed by Yamagishi Kazutoshi
parent 6b2f4f8c09
commit 22caa32ba2
2 changed files with 54 additions and 5 deletions

View file

@ -0,0 +1,52 @@
# frozen_string_literal: true
require 'rails_helper'
describe Api::Web::EmbedsController do
render_views
let(:user) { Fabricate(:user) }
before { sign_in user }
describe 'POST #create' do
subject(:response) { post :create, params: { url: url } }
subject(:body) { JSON.parse(response.body, symbolize_names: true) }
context 'when successfully finds status' do
let(:status) { Fabricate(:status) }
let(:url) { "http://#{ Rails.configuration.x.web_domain }/@#{status.account.username}/#{status.id}" }
it 'returns a right response' do
expect(response).to have_http_status :ok
expect(body[:author_name]).to eq status.account.username
end
end
context 'when fails to find status' do
let(:url) { 'https://host.test/oembed.html' }
let(:service_instance) { double('fetch_oembed_service') }
before do
allow(FetchOEmbedService).to receive(:new) { service_instance }
allow(service_instance).to receive(:call) { call_result }
end
context 'when successfully fetching oembed' do
let(:call_result) { { result: :ok } }
it 'returns a right response' do
expect(response).to have_http_status :ok
expect(body[:result]).to eq 'ok'
end
end
context 'when fails to fetch oembed' do
let(:call_result) { nil }
it 'returns a right response' do
expect(response).to have_http_status :not_found
end
end
end
end
end

View file

@ -6,10 +6,11 @@ describe StatusFinder do
include RoutingHelper include RoutingHelper
describe '#status' do describe '#status' do
subject { described_class.new(url) }
context 'with a status url' do context 'with a status url' do
let(:status) { Fabricate(:status) } let(:status) { Fabricate(:status) }
let(:url) { short_account_status_url(account_username: status.account.username, id: status.id) } let(:url) { short_account_status_url(account_username: status.account.username, id: status.id) }
subject { described_class.new(url) }
it 'finds the stream entry' do it 'finds the stream entry' do
expect(subject.status).to eq(status) expect(subject.status).to eq(status)
@ -27,7 +28,6 @@ describe StatusFinder do
context 'with a stream entry url' do context 'with a stream entry url' do
let(:stream_entry) { Fabricate(:stream_entry) } let(:stream_entry) { Fabricate(:stream_entry) }
let(:url) { account_stream_entry_url(stream_entry.account, stream_entry) } let(:url) { account_stream_entry_url(stream_entry.account, stream_entry) }
subject { described_class.new(url) }
it 'finds the stream entry' do it 'finds the stream entry' do
expect(subject.status).to eq(stream_entry.status) expect(subject.status).to eq(stream_entry.status)
@ -37,7 +37,6 @@ describe StatusFinder do
context 'with a remote url even if id exists on local' do context 'with a remote url even if id exists on local' do
let(:status) { Fabricate(:status) } let(:status) { Fabricate(:status) }
let(:url) { "https://example.com/users/test/statuses/#{status.id}" } let(:url) { "https://example.com/users/test/statuses/#{status.id}" }
subject { described_class.new(url) }
it 'raises an error' do it 'raises an error' do
expect { subject.status }.to raise_error(ActiveRecord::RecordNotFound) expect { subject.status }.to raise_error(ActiveRecord::RecordNotFound)
@ -46,7 +45,6 @@ describe StatusFinder do
context 'with a plausible url' do context 'with a plausible url' do
let(:url) { 'https://example.com/users/test/updates/123/embed' } let(:url) { 'https://example.com/users/test/updates/123/embed' }
subject { described_class.new(url) }
it 'raises an error' do it 'raises an error' do
expect { subject.status }.to raise_error(ActiveRecord::RecordNotFound) expect { subject.status }.to raise_error(ActiveRecord::RecordNotFound)
@ -55,7 +53,6 @@ describe StatusFinder do
context 'with an unrecognized url' do context 'with an unrecognized url' do
let(:url) { 'https://example.com/about' } let(:url) { 'https://example.com/about' }
subject { described_class.new(url) }
it 'raises an error' do it 'raises an error' do
expect { subject.status }.to raise_error(ActiveRecord::RecordNotFound) expect { subject.status }.to raise_error(ActiveRecord::RecordNotFound)