Add tests for invites controller (#7441)

* Add tests for invites controller

* Small refactoring and fix for invites controller
This commit is contained in:
Shuhei Kitagawa 2018-05-11 20:14:33 +09:00 committed by Eugen Rochko
parent 1337ca837b
commit 50491e0d92
2 changed files with 75 additions and 4 deletions

View file

@ -8,9 +8,9 @@ class InvitesController < ApplicationController
before_action :authenticate_user! before_action :authenticate_user!
def index def index
authorize :invite, :create? authorize :invite, :index?
@invites = Invite.where(user: current_user) @invites = invites
@invite = Invite.new(expires_in: 1.day.to_i) @invite = Invite.new(expires_in: 1.day.to_i)
end end
@ -23,13 +23,13 @@ class InvitesController < ApplicationController
if @invite.save if @invite.save
redirect_to invites_path redirect_to invites_path
else else
@invites = Invite.where(user: current_user) @invites = invites
render :index render :index
end end
end end
def destroy def destroy
@invite = Invite.where(user: current_user).find(params[:id]) @invite = invites.find(params[:id])
authorize @invite, :destroy? authorize @invite, :destroy?
@invite.expire! @invite.expire!
redirect_to invites_path redirect_to invites_path
@ -37,6 +37,10 @@ class InvitesController < ApplicationController
private private
def invites
Invite.where(user: current_user)
end
def resource_params def resource_params
params.require(:invite).permit(:max_uses, :expires_in) params.require(:invite).permit(:max_uses, :expires_in)
end end

View file

@ -0,0 +1,67 @@
require 'rails_helper'
describe InvitesController do
render_views
before do
sign_in user
end
describe 'GET #index' do
subject { get :index }
let!(:invite) { Fabricate(:invite, user: user) }
context 'when user is a staff' do
let(:user) { Fabricate(:user, moderator: true, admin: false) }
it 'renders index page' do
expect(subject).to render_template :index
expect(assigns(:invites)).to include invite
expect(assigns(:invites).count).to eq 1
end
end
context 'when user is not a staff' do
let(:user) { Fabricate(:user, moderator: false, admin: false) }
it 'returns 403' do
expect(subject).to have_http_status 403
end
end
end
describe 'POST #create' do
subject { post :create, params: { invite: { max_uses: '10', expires_in: 1800 } } }
context 'when user is an admin' do
let(:user) { Fabricate(:user, moderator: false, admin: true) }
it 'succeeds to create a invite' do
expect{ subject }.to change { Invite.count }.by(1)
expect(subject).to redirect_to invites_path
expect(Invite.last).to have_attributes(user_id: user.id, max_uses: 10)
end
end
context 'when user is not an admin' do
let(:user) { Fabricate(:user, moderator: true, admin: false) }
it 'returns 403' do
expect(subject).to have_http_status 403
end
end
end
describe 'DELETE #create' do
subject { delete :destroy, params: { id: invite.id } }
let!(:invite) { Fabricate(:invite, user: user, expires_at: nil) }
let(:user) { Fabricate(:user, moderator: false, admin: true) }
it 'expires invite' do
expect(subject).to redirect_to invites_path
expect(invite.reload).to be_expired
end
end
end