asonix/chess-server
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Add long polling for game state #4

Merged
asonix merged 5 commits from asonix/long-polling into kumu 2022-01-13 23:15:20 +00:00
Conversation 0 Commits 5 Files changed 4 +145 -71
asonix commented 2022-01-03 02:39:17 +00:00
Owner
Copy link

Implement long polling for state updates

Implement long polling for state updates
asonix added 1 commit 2022-01-03 02:39:18 +00:00
Some checks failed
continuous-integration/drone/push Build is failing
Details
continuous-integration/drone/pr Build is failing
Details
4f88cdc81e Add long polling for game state
asonix added 1 commit 2022-01-03 02:42:37 +00:00
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
6010d16cd4 Allow async-yields-async
asonix added 1 commit 2022-01-08 04:09:28 +00:00
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
8f52495788 Only return board from Poll, add optional PieceKind to Move
asonix added 1 commit 2022-01-08 04:11:10 +00:00
Some checks failed
continuous-integration/drone/push Build is failing
Details
continuous-integration/drone/pr Build is failing
Details
730470bf9f Proper board response naming
asonix added 1 commit 2022-01-08 04:11:34 +00:00
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
c7aea84979 Proper board response naming 2
Kumu approved these changes 2022-01-13 23:06:30 +00:00
Kumu left a comment
Collaborator
Copy link

other than the one comment I had, lgtm, idrk what long polling is though

other than the one comment I had, lgtm, idrk what long polling is though
src/api_types.rs
@ -66,0 +68,4 @@
Clone, Debug, PartialEq, Eq, PartialOrd, Ord, Hash, serde::Deserialize, serde::Serialize,
)]
#[serde(rename_all = "camelCase")]
pub(crate) enum GameState {
Kumu commented 2022-01-13 23:05:31 +00:00
Collaborator
Copy link

Imo could be a better name, since GameState at least to me is the state of the entire game and all of its information, like where pieces are, etc. Unfortunately I don't have a better name off the top of my head.

Win/Lose values seem slightly ambiguous since it's not specified for which player.

Imo could be a better name, since GameState at least to me is the state of the entire game and all of its information, like where pieces are, etc. Unfortunately I don't have a better name off the top of my head. Win/Lose values seem slightly ambiguous since it's not specified for which player.
asonix merged commit 4160032cba into kumu 2022-01-13 23:15:20 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Kumu
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: asonix/chess-server#4
No description provided.
Delete branch "asonix/long-polling"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?